-
Notifications
You must be signed in to change notification settings - Fork 453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove .net core 2.1 support #3441
Conversation
…eapp2.1 # Conflicts: # Source/LinqToDB/Data/CommandInfo.cs # Tests/Linq/Data/MiniProfilerTests.cs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - not approving since draft
Update CONTRIBUTING.md to remove references to netcoreapp2.1 and related defines |
Which references? I don't see any left |
Weird, when I looked earlier, only 7 files changed, and CONTRIBUTING was not one fo them. I'll re-read now that GH is showing all of the files... /sigh |
- remove windows 2016 from CI - fix sqlite runtime load in netfx tests
/azp run test-sqlite |
Azure Pipelines successfully started running 1 pipeline(s). |
…eapp2.1 # Conflicts: # Build/Azure/pipelines/templates/test-jobs.yml # Tests/FSharp/Tests.FSharp.fsproj
/azp run test-sqlite |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run test-sqlite |
Azure Pipelines successfully started running 1 pipeline(s). |
I still need to fix CI testing, but otherwise it is ready for review |
Test baselines changed by this PR. Don't forget to merge/close baselines PR after this pr merged/closed. |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run test-all |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run test-all |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run test-all |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run test-all |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run test-all |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run test-all |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run test-all |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run test-all |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run test-all |
Azure Pipelines successfully started running 1 pipeline(s). |
* [Windows / SQL Server EXTRAS] baselines * [Linux / SQL Server 2019] baselines * [Windows / Access ACE (OLEDB/ODBC) x64] baselines * [Linux / DB2 LUW 11.5] baselines * [Linux / DB2 LUW 11.5] baselines * [Windows / SQL Server EXTRAS] baselines * [Windows / SQLite (specialized tests)] baselines * [Linux / SQL Server 2019] baselines * [Windows / SQL Server 2012] baselines * [Windows / SQL Server 2005] baselines * [Windows / SQL Server 2017] baselines * [Windows / SQL Server 2016] baselines * [Windows / SQL Server EXTRAS] baselines * [Windows / SQL Server 2019] baselines Co-authored-by: Azure Pipelines Bot <azp@linq2db.com>
.net core 2.1
support (users still can uselinq2db
there withnetstandard2.0
builds). 2.1 reached EOL last year and it became a PITA to support builds with tooling changesDisposeCommand
method to fix detected sync-over-async casesExecuteScope
method to support async to fix detected sync-over-async casesSystem.Text.Json
in tests fromnewtownsoft.json
windows-2016
image use as it will be removed soon from Azure.No SQL Server NETFX tests for now as we don't have suitable docker imagesrepelacement images found!Remaining tasks:
windows-2019
image test workflowPostgreSQL 9 support removal will go in separate PR if approved.